Skip to content

Commit ce536c9

Browse files
authored
Implement tree explain for LazyMemoryExec (#15187)
Resolve conflicts
1 parent 3cfcdb6 commit ce536c9

File tree

2 files changed

+30
-3
lines changed

2 files changed

+30
-3
lines changed

datafusion/physical-plan/src/memory.rs

+11-2
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,17 @@ impl DisplayAs for LazyMemoryExec {
193193
)
194194
}
195195
DisplayFormatType::TreeRender => {
196-
// TODO: collect info
197-
write!(f, "")
196+
//TODO: remove batch_size, add one line per generator
197+
writeln!(
198+
f,
199+
"batch_generators={}",
200+
self.batch_generators
201+
.iter()
202+
.map(|g| g.read().to_string())
203+
.collect::<Vec<String>>()
204+
.join(", ")
205+
)?;
206+
Ok(())
198207
}
199208
}
200209
}

datafusion/sqllogictest/test_files/explain_tree.slt

+19-1
Original file line numberDiff line numberDiff line change
@@ -725,7 +725,12 @@ physical_plan
725725
32)└─────────────┬─────────────┘
726726
33)┌─────────────┴─────────────┐
727727
34)│ LazyMemoryExec │
728-
35)└───────────────────────────┘
728+
35)│ -------------------- │
729+
36)│ batch_generators: │
730+
37)│ generate_series: start=1, │
731+
38)│ end=1000, batch_size │
732+
39)│ =8192 │
733+
40)└───────────────────────────┘
729734

730735
query TT
731736
explain select
@@ -1641,3 +1646,16 @@ physical_plan
16411646
08)│ format: memory │
16421647
09)│ rows: 1 │
16431648
10)└───────────────────────────┘
1649+
1650+
# Test explain tree for LazyMemoryExec
1651+
query TT
1652+
EXPLAIN SELECT * FROM generate_series(1, 100)
1653+
----
1654+
physical_plan
1655+
01)┌───────────────────────────┐
1656+
02)│ LazyMemoryExec │
1657+
03)│ -------------------- │
1658+
04)│ batch_generators: │
1659+
05)│ generate_series: start=1, │
1660+
06)│ end=100, batch_size=8192 │
1661+
07)└───────────────────────────┘

0 commit comments

Comments
 (0)