File tree 1 file changed +4
-3
lines changed
datafusion/expr-common/src
1 file changed +4
-3
lines changed Original file line number Diff line number Diff line change @@ -247,9 +247,10 @@ impl TypeSignatureClass {
247
247
TypeSignatureClass :: Timestamp if logical_type. is_timestamp ( ) => {
248
248
Ok ( origin_type. to_owned ( ) )
249
249
}
250
- TypeSignatureClass :: Timestamp => {
251
- // TODO: Consider allowing the user to specify the default timestamp type instead of having it predefined in DataFusion when we have such use case
252
- // Use default timestamp type with nanosecond precision and no timezone
250
+ // This is an existing use case for casting string to timestamp, since we don't have specific unit and timezone from string,
251
+ // so we use the default timestamp type with nanosecond precision and no timezone
252
+ // TODO: Consider allowing the user to specify the default timestamp type instead of having it predefined in DataFusion when we have more use cases
253
+ TypeSignatureClass :: Timestamp if logical_type == & NativeType :: String => {
253
254
logical_timestamp ( ) . default_cast_for ( origin_type)
254
255
}
255
256
TypeSignatureClass :: Date if logical_type. is_date ( ) => {
You can’t perform that action at this time.
0 commit comments