Skip to content

Commit 929da68

Browse files
committed
fix doc
1 parent 330f2ac commit 929da68

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

datafusion/functions-aggregate/src/hyperloglog.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
//! `hyperloglog` is a module that contains a modified version
2121
//! of [redis's implementation](https://github.com/redis/redis/blob/4930d19e70c391750479951022e207e19111eb55/src/hyperloglog.c)
2222
//! with some modification based on strong assumption of usage
23-
//! within datafusion, so that [`datafusion_functions_aggregate::approx_distinct`] function can
23+
//! within datafusion, so that [`approx_distinct`] function can
2424
//! be efficiently implemented.
2525
//!
2626
//! Specifically, like Redis's version, this HLL structure uses

datafusion/physical-expr/src/aggregate/hyperloglog.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ where
115115

116116
/// Get the register histogram (each value in register index into
117117
/// the histogram; u32 is enough because we only have 2**14=16384 registers
118-
#[warn(dead_code)]
118+
#[allow(dead_code)]
119119
#[inline]
120120
fn get_histogram(&self) -> [u32; HLL_Q + 2] {
121121
let mut histogram = [0; HLL_Q + 2];
@@ -127,7 +127,7 @@ where
127127
}
128128

129129
/// Merge the other [`HyperLogLog`] into this one
130-
#[warn(dead_code)]
130+
#[allow(dead_code)]
131131
pub fn merge(&mut self, other: &HyperLogLog<T>) {
132132
assert!(
133133
self.registers.len() == other.registers.len(),
@@ -181,6 +181,7 @@ fn hll_sigma(x: f64) -> f64 {
181181
/// Helper function tau as defined in
182182
/// "New cardinality estimation algorithms for HyperLogLog sketches"
183183
/// Otmar Ertl, arXiv:1702.01284
184+
#[allow(dead_code)]
184185
#[inline]
185186
fn hll_tau(x: f64) -> f64 {
186187
if x == 0.0 || x == 1.0 {

0 commit comments

Comments
 (0)