Skip to content

Commit 79bcb29

Browse files
blagininblaginin
committed
Fix tests
1 parent d54c9ca commit 79bcb29

File tree

4 files changed

+32
-4
lines changed

4 files changed

+32
-4
lines changed

‎datafusion-cli/tests/snapshots/cli_quick_test@change_format_version.snap

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
---
2+
source: datafusion-cli/tests/cli_integration.rs
3+
info:
4+
program: datafusion-cli
5+
args:
6+
- "--file"
7+
- tests/sql/types_format.sql
8+
- "-q"
9+
---
10+
success: true
11+
exit_code: 0
12+
----- stdout -----
13+
+-----------+
14+
| Int64(54) |
15+
| Int64 |
16+
+-----------+
17+
| 54 |
18+
+-----------+
19+
20+
----- stderr -----

‎datafusion/common/src/config.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -734,7 +734,6 @@ config_namespace! {
734734

735735
/// Display format of explain. Default is "indent".
736736
/// When set to "tree", it will print the plan in a tree-rendered format.
737-
/// No need to normalize because ExplainFormat is case-insensitive
738737
pub format: String, default = "indent".to_string()
739738
}
740739
}
@@ -769,7 +768,7 @@ config_namespace! {
769768
pub timestamp_format: Option<String>, default = None
770769
/// Timestamp format for timestamp with timezone arrays
771770
pub timestamp_tz_format: Option<String>, default = None
772-
/// Time format for time arrcays
771+
/// Time format for time arrays
773772
pub time_format: Option<String>, default = None
774773
/// Duration format. Can be either Pretty or ISO8601
775774
pub duration_format: String, default = "pretty".into()

‎datafusion/sqllogictest/test_files/information_schema.slt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ datafusion.execution.split_file_groups_by_statistics false Attempt to eliminate
375375
datafusion.execution.target_partitions 7 Number of partitions for query execution. Increasing partitions can increase concurrency. Defaults to the number of CPU cores on the system
376376
datafusion.execution.time_zone +00:00 The default time zone Some functions, e.g. `EXTRACT(HOUR from SOME_TIME)`, shift the underlying datetime according to this time zone, and then extract the hour
377377
datafusion.execution.use_row_number_estimates_to_optimize_partitioning false Should DataFusion use row number estimates at the input to decide whether increasing parallelism is beneficial or not. By default, only exact row numbers (not estimates) are used for this decision. Setting this flag to `true` will likely produce better plans. if the source of statistics is accurate. We plan to make this the default in the future.
378-
datafusion.explain.format indent Display format of explain. Default is "indent". When set to "tree", it will print the plan in a tree-rendered format. No need to normalize because ExplainFormat is case-insensitive
378+
datafusion.explain.format indent Display format of explain. Default is "indent". When set to "tree", it will print the plan in a tree-rendered format.
379379
datafusion.explain.logical_plan_only false When set to true, the explain statement will only print logical plans
380380
datafusion.explain.physical_plan_only false When set to true, the explain statement will only print physical plans
381381
datafusion.explain.show_schema false When set to true, the explain statement will print schema information
@@ -386,7 +386,7 @@ datafusion.format.datetime_format NULL Format for DateTime arrays
386386
datafusion.format.duration_format pretty Duration format. Can be either Pretty or ISO8601
387387
datafusion.format.null (empty) Format string for nulls
388388
datafusion.format.safe true If set to `true` any formatting errors will be written to the output instead of being converted into a [`std::fmt::Error`]
389-
datafusion.format.time_format NULL Time format for time arrcays
389+
datafusion.format.time_format NULL Time format for time arrays
390390
datafusion.format.timestamp_format NULL Timestamp format for timestamp arrays
391391
datafusion.format.timestamp_tz_format NULL Timestamp format for timestamp with timezone arrays
392392
datafusion.format.types_info false Show types in visual representation batches

‎docs/source/user-guide/configs.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,3 +132,12 @@ Environment variables are read during `SessionConfig` initialisation so they mus
132132
| datafusion.sql_parser.map_varchar_to_utf8view | false | If true, `VARCHAR` is mapped to `Utf8View` during SQL planning. If false, `VARCHAR` is mapped to `Utf8` during SQL planning. Default is false. |
133133
| datafusion.sql_parser.collect_spans | false | When set to true, the source locations relative to the original SQL query (i.e. [`Span`](https://docs.rs/sqlparser/latest/sqlparser/tokenizer/struct.Span.html)) will be collected and recorded in the logical plan nodes. |
134134
| datafusion.sql_parser.recursion_limit | 50 | Specifies the recursion depth limit when parsing complex SQL Queries |
135+
| datafusion.format.safe | true | If set to `true` any formatting errors will be written to the output instead of being converted into a [`std::fmt::Error`] |
136+
| datafusion.format.null | | Format string for nulls |
137+
| datafusion.format.date_format | NULL | Date format for date arrays |
138+
| datafusion.format.datetime_format | NULL | Format for DateTime arrays |
139+
| datafusion.format.timestamp_format | NULL | Timestamp format for timestamp arrays |
140+
| datafusion.format.timestamp_tz_format | NULL | Timestamp format for timestamp with timezone arrays |
141+
| datafusion.format.time_format | NULL | Time format for time arrays |
142+
| datafusion.format.duration_format | pretty | Duration format. Can be either Pretty or ISO8601 |
143+
| datafusion.format.types_info | false | Show types in visual representation batches |

0 commit comments

Comments
 (0)