Skip to content

Commit 2861ada

Browse files
Ian LaiIan Lai
Ian Lai
authored and
Ian Lai
committed
rewrite function using new_implicit for sha512
1 parent e4a82cf commit 2861ada

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

datafusion/functions/src/crypto/sha512.rs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
use super::basic::{sha512, utf8_or_binary_to_binary_type};
2020
use arrow::datatypes::DataType;
2121
use datafusion_common::{
22-
types::{logical_binary, logical_string},
22+
types::{logical_binary, logical_float64, logical_string, NativeType},
2323
Result,
2424
};
2525
use datafusion_expr::{
@@ -59,11 +59,15 @@ impl SHA512Func {
5959
Self {
6060
signature: Signature::one_of(
6161
vec![
62-
TypeSignature::Coercible(vec![Coercion::new_exact(
63-
TypeSignatureClass::Native(logical_string()),
62+
TypeSignature::Coercible(vec![Coercion::new_implicit(
63+
TypeSignatureClass::Native(logical_binary()),
64+
vec![TypeSignatureClass::Native(logical_string())],
65+
NativeType::String,
6466
)]),
65-
TypeSignature::Coercible(vec![Coercion::new_exact(
67+
TypeSignature::Coercible(vec![Coercion::new_implicit(
6668
TypeSignatureClass::Native(logical_binary()),
69+
vec![TypeSignatureClass::Native(logical_binary())],
70+
NativeType::Binary,
6771
)]),
6872
],
6973
Volatility::Immutable,

0 commit comments

Comments
 (0)