Update Arrow 45.0.0 And Datum Arithmetic, change Decimal Division semantics (#6832)

* Datum based arithmetic

* Update scalar timestamp arithmetic tests

* Clippy

* Update negation

* Update sqllogictests

* Update arrow 44.0.0

* Update for fixed size binary comparisons

* Clippy

* Update pin

* Override formatting

* Make test stable

* Remove temporary file

* Update datafusion-cli lockfile

* Update pin

* Format

* Move DEFAULT_FORMAT_OPTIONS to datafusion_common

---------

Co-authored-by: Andrew Lamb <[email protected]>

Author: tustvold

Cargo.toml

@@ -32,12 +32,12 @@ rust-version = "1.70"
 version = "28.0.0"
 
 [workspace.dependencies]
-arrow = { version = "43.0.0", features = ["prettyprint", "dyn_cmp_dict"] }
-arrow-array = { version = "43.0.0", default-features = false, features = ["chrono-tz"] }
-arrow-buffer = { version = "43.0.0", default-features = false }
-arrow-flight = { version = "43.0.0", features = ["flight-sql-experimental"] }
-arrow-schema = { version = "43.0.0", default-features = false }
-parquet = { version = "43.0.0", features = ["arrow", "async", "object_store"] }
+arrow = { version = "45.0.0", features = ["prettyprint", "dyn_cmp_dict"] }
+arrow-array = { version = "45.0.0", default-features = false, features = ["chrono-tz"] }
+arrow-buffer = { version = "45.0.0", default-features = false }
+arrow-flight = { version = "45.0.0", features = ["flight-sql-experimental"] }
+arrow-schema = { version = "45.0.0", default-features = false }
+parquet = { version = "45.0.0", features = ["arrow", "async", "object_store"] }
 sqlparser = { version = "0.36.1", features = ["visitor"] }
 
 [profile.release]

datafusion-cli/Cargo.lock

@@ -29,7 +29,7 @@ rust-version = "1.70"
 readme = "README.md"
 
 [dependencies]
-arrow = "43.0.0"
+arrow = "45.0.0"
 async-trait = "0.1.41"
 aws-config = "0.55"
 aws-credential-types = "0.55"

datafusion-cli/Cargo.toml

@@ -18,8 +18,9 @@
 //! Print format variants
 use arrow::csv::writer::WriterBuilder;
 use arrow::json::{ArrayWriter, LineDelimitedWriter};
+use arrow::util::pretty::pretty_format_batches_with_options;
 use datafusion::arrow::record_batch::RecordBatch;
-use datafusion::arrow::util::pretty;
+use datafusion::common::format::DEFAULT_FORMAT_OPTIONS;
 use datafusion::error::{DataFusionError, Result};
 use std::str::FromStr;
 
@@ -75,7 +76,12 @@ impl PrintFormat {
         match self {
             Self::Csv => println!("{}", print_batches_with_sep(batches, b',')?),
             Self::Tsv => println!("{}", print_batches_with_sep(batches, b'\t')?),
-            Self::Table => pretty::print_batches(batches)?,
+            Self::Table => {
+                println!(
+                    "{}",
+                    pretty_format_batches_with_options(batches, &DEFAULT_FORMAT_OPTIONS)?
+                )
+            }
             Self::Json => println!("{}", batches_to_json!(ArrayWriter, batches)),
             Self::NdJson => {
                 println!("{}", batches_to_json!(LineDelimitedWriter, batches))

datafusion-cli/src/print_format.rs

@@ -0,0 +1,22 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use arrow::util::display::{DurationFormat, FormatOptions};
+
+/// The default [`FormatOptions`] to use within DataFusion
+pub const DEFAULT_FORMAT_OPTIONS: FormatOptions<'static> =
+    FormatOptions::new().with_duration_format(DurationFormat::Pretty);

datafusion/common/src/format.rs

@@ -23,6 +23,7 @@ pub mod delta;
 mod dfschema;
 pub mod display;
 mod error;
+pub mod format;
 mod functional_dependencies;
 mod join_type;
 pub mod parsers;