Skip to content

Commit 10b0b7f

Browse files
authored
Update CHANGELOG (#192)
Also remove a comment with a trailing space, which rustfmt doesn't like
1 parent a42121d commit 10b0b7f

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ Given that the parser produces a typed AST, any changes to the AST will technica
99
Check https://github.com/andygrove/sqlparser-rs/commits/master for undocumented changes.
1010

1111
### Changed
12+
- **`Parser::parse_sql` now accepts a `&str` instead of `String` (#182)** - thanks @Dandandan!
1213
- Change `Ident` (previously a simple `String`) to store the parsed (unquoted) `value` of the identifier and the `quote_style` separately (#143) - thanks @apparebit!
1314
- Support Snowflake's `FROM (table_name)` (#155) - thanks @eyalleshem!
1415

@@ -21,6 +22,8 @@ Check https://github.com/andygrove/sqlparser-rs/commits/master for undocumented
2122
- Support basic forms of `CREATE SCHEMA` and `DROP SCHEMA` (#173) - thanks @alex-dukhno!
2223
- Support `NULLS FIRST`/`LAST` in `ORDER BY` expressions (#176) - thanks @houqp!
2324
- Support `LISTAGG()` (#174) - thanks @maxcountryman!
25+
- Support the string concatentation operator `||` (#178) - thanks @Dandandan!
26+
- Support bitwise AND (`&`), OR (`|`), XOR (`^`) (#181) - thanks @Dandandan!
2427

2528
### Fixed
2629
- Report an error for unterminated string literals (#165)

src/tokenizer.rs

-1
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,6 @@ impl Token {
143143
}
144144
pub fn make_word(word: &str, quote_style: Option<char>) -> Self {
145145
let word_uppercase = word.to_uppercase();
146-
//TODO: validate use of a hashset (e.g. FnvHashSet) compared to using binary search
147146
let is_keyword =
148147
quote_style == None && ALL_KEYWORDS.binary_search(&word_uppercase.as_str()).is_ok();
149148
Token::Word(Word {

0 commit comments

Comments
 (0)