Skip to content

Native shuffle inaccurate estimate of builder memory allocation #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andygrove opened this issue Feb 26, 2025 · 2 comments
Closed

Native shuffle inaccurate estimate of builder memory allocation #1449

andygrove opened this issue Feb 26, 2025 · 2 comments
Assignees
Labels
bug Something isn't working performance
Milestone

Comments

@andygrove
Copy link
Member

Describe the bug

As demonstrated in unit tests added in #1440, we are allocating ~100kb for a batch when the actual memory used in less than 10kb.

assert_eq!(8376, batch.get_array_memory_size());
assert_eq!(106496, buffer.reservation.size());

Rather than use the current slot_size logic that produces an estimate based on schema, it would be more accurate to estimate memory size based on the memory used by the incoming batches.

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

@andygrove andygrove added the bug Something isn't working label Feb 26, 2025
@andygrove andygrove self-assigned this Feb 26, 2025
@andygrove andygrove added this to the 0.7.0 milestone Feb 26, 2025
@andygrove andygrove modified the milestones: 0.7.0, 0.8.0 Mar 3, 2025
@dharanad
Copy link
Contributor

dharanad commented Mar 4, 2025

take

@andygrove
Copy link
Member Author

This issue was resolved in #1511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working performance
Projects
None yet
Development

No branches or pull requests

2 participants