Skip to content

Commit 01dadd7

Browse files
committed
fix
1 parent a2e24be commit 01dadd7

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala

+2-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import scala.collection.JavaConverters._
2323

2424
import org.apache.spark.internal.Logging
2525
import org.apache.spark.sql.catalyst.expressions._
26-
import org.apache.spark.sql.catalyst.expressions.aggregate.{AggregateExpression, Average, BitAndAgg, BitOrAgg, BitXorAgg, Complete, Corr, Count, CovPopulation, CovSample, Final, First, Last, Max, Min, Partial, StddevPop, StddevSamp, Sum, VariancePop, VarianceSamp}
26+
import org.apache.spark.sql.catalyst.expressions.aggregate.{AggregateExpression, Average, BitAndAgg, BitOrAgg, BitXorAgg, BloomFilterAggregate, Complete, Corr, Count, CovPopulation, CovSample, Final, First, Last, Max, Min, Partial, StddevPop, StddevSamp, Sum, VariancePop, VarianceSamp}
2727
import org.apache.spark.sql.catalyst.expressions.objects.StaticInvoke
2828
import org.apache.spark.sql.catalyst.optimizer.{BuildLeft, BuildRight, NormalizeNaNAndZero}
2929
import org.apache.spark.sql.catalyst.plans._
@@ -370,6 +370,7 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim
370370
case _: StddevSamp => CometStddevSamp
371371
case _: StddevPop => CometStddevPop
372372
case _: Corr => CometCorr
373+
case _: BloomFilterAggregate => CometBloomFilterAggregate
373374
case fn =>
374375
val msg = s"unsupported Spark aggregate function: ${fn.prettyName}"
375376
emitWarning(msg)

spark/src/main/scala/org/apache/comet/serde/aggregates.scala

+6-6
Original file line numberDiff line numberDiff line change
@@ -659,16 +659,16 @@ object CometBloomFilterAggregate extends CometAggregateExpressionSerde {
659659
numItemsExpr.isDefined &&
660660
numBitsExpr.isDefined &&
661661
dataType.isDefined) {
662-
val bloomFilterAggBuilder = ExprOuterClass.BloomFilterAgg.newBuilder()
663-
bloomFilterAggBuilder.setChild(childExpr.get)
664-
bloomFilterAggBuilder.setNumItems(numItemsExpr.get)
665-
bloomFilterAggBuilder.setNumBits(numBitsExpr.get)
666-
bloomFilterAggBuilder.setDatatype(dataType.get)
662+
val builder = ExprOuterClass.BloomFilterAgg.newBuilder()
663+
builder.setChild(childExpr.get)
664+
builder.setNumItems(numItemsExpr.get)
665+
builder.setNumBits(numBitsExpr.get)
666+
builder.setDatatype(dataType.get)
667667

668668
Some(
669669
ExprOuterClass.AggExpr
670670
.newBuilder()
671-
.setBloomFilterAgg(bloomFilterAggBuilder)
671+
.setBloomFilterAgg(builder)
672672
.build())
673673
} else {
674674
withInfo(

0 commit comments

Comments
 (0)