Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate assert/discriminator expressions after groupContent: WIP #987

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jadams-tresys
Copy link
Contributor

According to 9.5 of the DFDL spec assert and discriminators with expressions should be processed after the content of their enclosing sequence, group, or choice. Before these expressions were always being processed before the content.

This commit also moves the setVariable expression evaluaiton to the correct place, which is before the enclosing group.

DAFFODIL-1971, DAFFODIL-1590

According to 9.5 of the DFDL spec assert and discriminators with
expressions should be processed after the content of their enclosing
sequence, group, or choice. Before these expressions were always being
processed before the content.

This commit also moves the setVariable expression evaluaiton to the
correct place, which is before the enclosing group.

DAFFODIL-1971, DAFFODIL-1590
@jadams-tresys
Copy link
Contributor Author

jadams-tresys commented Mar 13, 2023

This is primarily WIP as it needs more test coverage and I have been informed that I need to hold off on working on this for a little while.

It is fully functional, just needs more tests for edge cases surrounding evaluating expressions after the content of sequences, groups, and choices.

Also need to add tests for the setVariable change.

@stevedlawrence stevedlawrence marked this pull request as draft September 18, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant