JSON output no longer quotes all values

[parkera101093]

JSONInfosetInputter and Outputter were treating all values as strings. This meant everyhing was quoted and was messier for the user to read. In addition, not all json comes from dfdl, so it makes sense to support numbers.

As of the time of this commit 156 tests fail as the changes cause some issues with dates and NaN, INF, and -INF values as well as numbers with a large amount of decimals such as 0.1234567898765432123456789 from test decimal_constructor_06.

DAFFODIL-2362

[stevedlawrence]

Looks good, just some suggestions for minor clean up and add a couple of tests to make sure we handle an error case correctly. I don't think we did before this change so it would be good to verify it's fixed and get a reasonable diagnostic now.

[stevedlawrence]

I think we can make this diagnostic more helpful to users. Maybe something like this:

"Unexpected array or object '" + getLocalName + "' on line " + jsp.getTokenLocation().getLineNr()

We should have a test that this fails correctly for both arrays and objects.

[stevedlawrence]

It's usually best to avoid string comparisons when there's something more specific available. String comparisons can silently break if we ever decide to change the string representation but don't check the condition. For example, Double and Float have isInfinite and isNaN functions.

This is also a pretty big if-statement. I might suggest moving this all to a separate private function, something like this:

private def needsQuote(simple: InofsetSimpleElement): Boolean = {
  simple.metadata.dfdlType match {
    case DFDLPrimType.String => true
    case DFDLPrimType.HexBinary => true
    case DFDLprimType.AnyURI => true
    ...
    // json does not support inf/nan double/float so they must be quoted
    case DFDLPrimType.Double => {
      val d = simple.getDouble
      d.isInfinite || d.isNaN
    }
    case DFDLPrimType.Float => {
      val f = simple.getFloat
      f.isInfinity || f.isNan
    }
    case _ => false
}

Then this is statement just becomes if (needsQuotes(simple)) ..... This makes it much easier to understand what this if-statement is checking for without having to decipher it. And it makes it easier to add comments for unexpected edgecases like inf/nan support.