Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace outdated parts of plugman with cordova-plugin-template and documentation #125

Open
janpio opened this issue Apr 29, 2019 · 4 comments

Comments

@janpio
Copy link
Member

janpio commented Apr 29, 2019

Those can probably be removed:

Author plugins
    create               Create a plugin
    createpackagejson    Add a package.json file to a plugin
    platform             Add and remove platforms from a plugin

Some input:

Oh look, something like this already exists:
https://github.com/phonegap/phonegap-plugin-template
https://github.com/cesilva/cordova-plugin-template

Unfortunately this is gone:
https://www.npmjs.com/package/cordova-plugin-template
Although we probably don't need to publish this to npm anyway.

@janpio
Copy link
Member Author

janpio commented Apr 29, 2019

TODO: Check if the actual library code here is used in Cordova somewhere else.

@raphinesse
Copy link
Contributor

raphinesse commented Apr 29, 2019

TODO: Check if the actual library code here is used in Cordova somewhere else.

This repository contains only the CLI of plugman. All actual functionality is implemented in cordova-lib/src/plugman. This "plugman library" contains some parts that are not used by anything but the plugman CLI and some parts that are also used during certain operations of Cordova CLI. I'll gladly do the deed of removing all unnecessary cruft, should we decide to do this.

Cordova package dependency graph for reference:
dependency graph

@janpio
Copy link
Member Author

janpio commented Apr 30, 2019

TODO done then - not necessary to think about that ;)

@janpio
Copy link
Member Author

janpio commented May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants