Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an Artemis container instead of quarkus-test-artemis in camel-quarkus-integration-test-jms-artemis-client #6364

Closed
ppalaga opened this issue Aug 20, 2024 · 5 comments

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Aug 20, 2024

Description

... to improve the robustness and lower the maintenance overhead.

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 20, 2024

cc @jamesnetherton

@jamesnetherton
Copy link
Contributor

Would be good to also apply this to the jms-jpa example if possible:

https://github.com/apache/camel-quarkus-examples/blob/8e3f6067ca6639fda54092366356b1a4d67c96a9/jms-jpa/pom.xml#L139-L143

@zhfeng
Copy link
Contributor

zhfeng commented Aug 20, 2024

It could impact the CustomArtemisTest

@UnlessBuildProperty(name = "quarkus.artemis.enabled", stringValue = "true")
ConnectionFactory createConnectionFactory() {
String url = ConfigProvider.getConfig().getValue("artemis.custom.url", String.class);
ActiveMQConnectionFactory cf = new ActiveMQConnectionFactory(url);
return cf;
}

@jamesnetherton
Copy link
Contributor

The main part is done in #6390. I'll fix up the jms-jpa example after camel-quarkus-main branch is reset for 3.15.

@jamesnetherton
Copy link
Contributor

apache/camel-quarkus-examples#258 completes this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants