Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of deprecated get_child_watcher #1990

Open
nanonyme opened this issue Feb 3, 2025 · 2 comments
Open

Fix usage of deprecated get_child_watcher #1990

nanonyme opened this issue Feb 3, 2025 · 2 comments

Comments

@nanonyme
Copy link
Contributor

nanonyme commented Feb 3, 2025

There's a new warning in BuildStream output

  /usr/lib64/python3.12/asyncio/events.py:828: DeprecationWarning: 'get_child_watcher' is deprecated as of Python 3.12 and will be removed in Python 3.14.
@nanonyme
Copy link
Contributor Author

nanonyme commented Feb 3, 2025

This is used in

buildstream/src/buildstream/_scheduler/scheduler.py

Line 163 in 936124f

_watcher = asyncio.get_child_watcher()

@nanonyme
Copy link
Contributor Author

nanonyme commented Feb 5, 2025

Looks like python/cpython#94597 is the issue with full context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nanonyme