Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BP-68: Delete cookie as part of decommission API. #4500

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

Karthickramk
Copy link
Contributor

Descriptions of the changes in this PR:

New BP for deleting cookie as part of bookkeeper decommission API
#4499
Proposal PR: WIP

Copy link
Member

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shoothzj
Copy link
Member

It's http body or url param?

{
"delete_cookie": true
}

or

?delete_cookie=true

@Karthickramk
Copy link
Contributor Author

Karthickramk commented Sep 12, 2024 via email

Copy link
Member

@wenbingshen wenbingshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The default behavior is sufficient to maintain forward compatibility.

@StevenLuMT StevenLuMT merged commit 222345f into apache:master Sep 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants