Simplify getting project version in release script #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eolivelli @nicoloboschi please review |
eolivelli
approved these changes
Mar 21, 2024
nicoloboschi
pushed a commit
that referenced
this pull request
Mar 21, 2024
(cherry picked from commit ca98a7e)
eolivelli
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit ca98a7e)
lhotari
added a commit
that referenced
this pull request
Jun 13, 2024
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The 000-run-docker.sh script didn't work for me with my configs.
Changes
Use an alternative way to get project.version