(WIP) Auditor.checkAllLedgers should use Auditor's instance variables #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- currently checkAllLedgers method creates instances of ZK, BK and BKAdmin everytime this method is called. Instead it should use Auditors instance variables.
|
retest this please |
sijie
approved these changes
Aug 9, 2018
|
few replication tests are failing. Will check that. |
reddycharan
changed the title
|
the change here will introduce deadlock so this PR needs to be revisited. See comment: |
|
@reddycharan this patch got enough consensus to be committed. cc @sijie |
|
Oh I missed @sijie 's comment. we should revisit this patch or close it |
|
@reddycharan this patch was already approved by @sijie do you mind rebasing it to current master ? |
|
@reddycharan can you please rebase to master and push? This is a useful patch to have. |
|
@eolivelli @sijie I went through the current implementation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
everytime this method is called. Instead it should use Auditors instance
variables.