From b5b518182b7cea448273dbfad1e307460d782423 Mon Sep 17 00:00:00 2001 From: Hang Chen Date: Tue, 5 Mar 2024 00:13:05 +0800 Subject: [PATCH] Fix error stack track may expose to external user (#4223) * fix error stack track may expose to external user * update code * fix check style --- .../http/servlet/BookieHttpServiceServlet.java | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/bookkeeper-http/servlet-http-server/src/main/java/org/apache/bookkeeper/http/servlet/BookieHttpServiceServlet.java b/bookkeeper-http/servlet-http-server/src/main/java/org/apache/bookkeeper/http/servlet/BookieHttpServiceServlet.java index 10f7b119148..30fe063786a 100644 --- a/bookkeeper-http/servlet-http-server/src/main/java/org/apache/bookkeeper/http/servlet/BookieHttpServiceServlet.java +++ b/bookkeeper-http/servlet-http-server/src/main/java/org/apache/bookkeeper/http/servlet/BookieHttpServiceServlet.java @@ -35,7 +35,6 @@ import org.apache.bookkeeper.http.HttpServer; import org.apache.bookkeeper.http.HttpServer.ApiType; import org.apache.bookkeeper.http.HttpServiceProvider; -import org.apache.bookkeeper.http.service.ErrorHttpService; import org.apache.bookkeeper.http.service.HttpEndpointService; import org.apache.bookkeeper.http.service.HttpServiceRequest; import org.apache.bookkeeper.http.service.HttpServiceResponse; @@ -91,16 +90,12 @@ protected void service(HttpServletRequest httpRequest, HttpServletResponse httpR return; } response = httpEndpointService.handle(request); - } catch (Throwable e) { - LOG.error("Error while service Bookie API request " + uri, e); - response = new ErrorHttpService().handle(request); - } - if (response != null) { httpResponse.setStatus(response.getStatusCode()); try (Writer out = httpResponse.getWriter()) { out.write(response.getBody()); } - } else { + } catch (Throwable e) { + LOG.error("Error while service Bookie API request {}", uri, e); httpResponse.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR); } }