Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker search #32750

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix docker search #32750

merged 1 commit into from
Oct 11, 2024

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Oct 11, 2024

Weirdly, searching for apache/beam does much better than apache/beam_ when using docker search. This was causing us to miss real images which we needed to push. For example, here are the top 20 results for each.

With my changes:

docker search "apache/beam" --format "{{.Name}}" --limit 100
apache/beam_go_sdk
apache/beam_java11_sdk
apache/beam_python3.8_sdk
apache/beam_python3.7_sdk
apache/beam_java8_sdk
apache/beam_python3.10_sdk
apache/beam_python3.11_sdk
apache/beam_python3.9_sdk
apache/beam_java17_sdk
apache/beam_java_sdk
apache/beam_python3.6_sdk
apache/beam_spark_job_server
apache/beam_flink1.13_job_server
apache/beam_spark3_job_server
apache/beam_flink1.12_job_server
apache/beam_java21_sdk
apache/beam_flink1.14_job_server
apache/beam_flink1.16_job_server
apache/beam_flink1.15_job_server
apache/beam_flink1.10_job_server
apache/beam_flink1.9_job_server
apache/beam_python2.7_sdk
apache/beam_flink1.8_job_server
apache/beam_flink1.11_job_server
apache/beam_python3.5_sdk
apache/airflow
apache/superset
apache/beam_python3.12_sdk
bitnami/apache
apache/beam_flink1.7_job_server

Without my changes:

docker search "apache/beam_" --format "{{.Name}}" --limit 100
apache/airflow
apache/superset
bitnami/apache
apache/couchdb
apache/solr-operator
apache/tika
apache/apisix
apache/nifi
apache/nifi-registry
apache/skywalking-oap-server
apache/apisix-dashboard
apache/dolphinscheduler
apache/arrow-dev
apache/spark
apache/druid
apache/flink
apache/cassandra-testing-ubuntu2004-java11-w-dependencies
apache/cassandra-testing-ubuntu2004-java11
apache/fineract
apache/skywalking-ui
apache/zeppelin
apache/skywalking-java-agent
apache/devlake
apache/devlake-dashboard
apache/camel-k
apache/devlake-config-ui
apache/beam_java11_sdk
apache/rocketmq
apache/kafka
apache/ozone-runner

Once this is in, we should rerun release finalization for the most recent release. Addresses #32731


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Oct 11, 2024
@damccorm
Copy link
Contributor Author

R: @Abacn

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damccorm damccorm merged commit e7ec432 into master Oct 11, 2024
3 checks passed
@damccorm damccorm deleted the users/damccorm/dockerSearch branch October 11, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants