fix: generate random index name for change streams #32689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generates index names for change stream partition metadata table using a random UUID. This prevents issues if the job is being redeployed in an existing database.
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
retest this please |
dedocibula
reviewed
Oct 9, 2024
...n/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/PartitionMetadataTableNames.java
Show resolved
Hide resolved
Finds and drops all indexes on the metadata table before attempting to drop it.
dedocibula
reviewed
Oct 9, 2024
...src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/PartitionMetadataDao.java
Outdated
Show resolved
Hide resolved
If a table is given, we still need to generate the index names in case the given table does not exist and needs to be created.
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damondouglas for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
dedocibula
approved these changes
Oct 10, 2024
|
Is this a fix for issue #32509? If so, can you add a "fixes: " in the description please? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates index names for change stream partition metadata table using a random UUID. This prevents issues if the job is being redeployed in an existing database.