Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Read with Meatadata in MqttIO #32668

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

twosom
Copy link
Contributor

@twosom twosom commented Oct 6, 2024

Please add a meaningful description for your change here

fixes #32195

This PR contains these changes

  • add support for read with metadata in MqttIO
  • add related test

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

github-actions bot commented Oct 6, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks great! Left a couple of suggestions but will leave it up to you

@twosom
Copy link
Contributor Author

twosom commented Oct 7, 2024

This change looks great! Left a couple of suggestions but will leave it up to you

@ahmedabu98
Thank you for your feedback! ^_^
I will do my best to incorporate it!

- remove MqttRecordCoder
- refactor MqttRecord to use AutoValueSchema
- change related test
@ahmedabu98
Copy link
Contributor

Looks great! merging now

@ahmedabu98 ahmedabu98 merged commit 95bf983 into apache:master Oct 10, 2024
20 checks passed
@Abacn
Copy link
Contributor

Abacn commented Oct 10, 2024

The added test is flaky: https://github.com/apache/beam/runs/31378942008

Testing MqttIO has been challenging, for example sleep were added in some test to mitigate the timing issue: #32500 . Or consider using countdown, etc to handle async

@twosom
Copy link
Contributor Author

twosom commented Oct 11, 2024

The added test is flaky: https://github.com/apache/beam/runs/31378942008

Testing MqttIO has been challenging, for example sleep were added in some test to mitigate the timing issue: #32500 . Or consider using countdown, etc to handle async

@Abacn
Thank you for your comment.
I'll fix the test as soon as possible.

@twosom twosom mentioned this pull request Oct 13, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add Topic Information to MqttIO Return Value
3 participants