Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [Python] BatchElements and ToList website examples are broken #32544

Closed
3 of 17 tasks
hjtran opened this issue Sep 24, 2024 · 12 comments
Closed
3 of 17 tasks

[Bug]: [Python] BatchElements and ToList website examples are broken #32544

hjtran opened this issue Sep 24, 2024 · 12 comments

Comments

@hjtran
Copy link
Contributor

hjtran commented Sep 24, 2024

What happened?

https://beam.apache.org/documentation/transforms/python/aggregation/batchelements/
https://beam.apache.org/documentation/transforms/python/aggregation/tolist/

These were introduced by #30788

I checked in Beam Playground with print(beam.__version__) and it looks like it's' running 2.56 which is when these examples were added. I'm not sure if maybe there's an extra step somewhere to update some database of examples used for the website?

Issue Priority

Priority: 2 (default / most bugs should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Infrastructure
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@hjtran
Copy link
Contributor Author

hjtran commented Sep 24, 2024

@damccorm You helped me with the original PR. Any idea what's missing here?

@Amar3tto
Copy link
Contributor

I think I already fixed broken examples here: #31647.
I guess there is need to update website

@tvalentyn
Copy link
Contributor

Also came across this issue; to my knowledge, the website is are being updated regularly, most likely additional changes are necessary

@tvalentyn
Copy link
Contributor

@Amar3tto For example, fixes in #31778 point to currently working examples

@Amar3tto
Copy link
Contributor

Also came across this issue; to my knowledge, the website is are being updated regularly, most likely additional changes are necessary

The website uses beam 2.56.0 which doesn't have transforms with the correct names

@damccorm
Copy link
Contributor

I don't think the problem is with the website, it is with the playground itself. If you click through to playground, the same problem exists - https://play.beam.apache.org/?path=SDK_PYTHON_ToList&sdk=python

@volatilemolotov
Copy link
Contributor

There was a issue in inline yaml for prod playground deploy. That is fixed and is running 2.59 now

@Amar3tto
Copy link
Contributor

The version has been updated, but the examples are still broken. We are working on it.

@hjtran
Copy link
Contributor Author

hjtran commented Sep 27, 2024

Thanks for the update!

@Amar3tto
Copy link
Contributor

Amar3tto commented Oct 2, 2024

Looks like all examples are fixed

@hjtran
Copy link
Contributor Author

hjtran commented Oct 2, 2024

Confirmed they look good. Thanks for the fix!!

@tvalentyn
Copy link
Contributor

Thanks all!

@github-actions github-actions bot added this to the 2.61.0 Release milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants