Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java11 Migration] Migrate Go testing to use Java11 container image for xlang #32212

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

lostluck
Copy link
Contributor

The default Xlang transforms got moved to Java 11, but we were only building the Java8 ones, so 11 wasn't available.

Move to use Java 11 to unbreak the existing tests.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@lostluck
Copy link
Contributor Author

R: @Abacn
cc: @damondouglas

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm also actively fixing tests. Let's do something like this:

https://github.com/apache/beam/pull/32190/files#diff-3b0c84ea390ab209fe959cda93b113ce47f7485f1b6046bbc5597da7d17f784dR44

So it always depend on current Java version

@github-actions github-actions bot added the build label Aug 15, 2024
@lostluck
Copy link
Contributor Author

I went a slightly different direction to go with the same way we set the Flink version string, instead of making all the files do an import (which they don't do presently), and needing a side variable. Let's see if I did it right...

@Abacn
Copy link
Contributor

Abacn commented Aug 15, 2024

I went a slightly different direction to go with the same way we set the Flink version string, instead of making all the files do an import (which they don't do presently), and needing a side variable. Let's see if I did it right...

Yeah this should work well. For the link above it was due to the file being "commons.gradle" instead of "build.gradle", where not explicitly applied (though all reference to "commons.gradle" called the plugin before) so I chose not to depend on project.ext initialized by apply : beamModulePlugin

@lostluck lostluck merged commit ced67ec into apache:master Aug 15, 2024
18 checks passed
@lostluck lostluck deleted the fixJava8Issues branch August 15, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants