Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#31926] [java] call provision service when creating external workers. #32198

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

lostluck
Copy link
Contributor

This fixes metrics from the Java SDK when running in Loopback mode against Prism (and probably a few other usecases too).

  • The Provision API is usually called by the container bootloader to initialize the worker.
  • Without calling the ProvisionAPI, the worker doesn't know a runner's capabilities.
  • This lead to the Java SDK to send old style metrics in loopback mode, which prism doesn't support.
  • That meant there were no metrics being propagated at in the UI.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Aug 15, 2024
@lostluck
Copy link
Contributor Author

R: @damondouglas

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@lostluck lostluck merged commit cbe2b9e into apache:master Aug 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants