[#31927,#31928][prism] Support StringSet and Gauge metrics. #32184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
The failing precommits (assuming the re-runs also fail again) are unrelated. Apparently the current development Java image doesn't exist. |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
damondouglas
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implementations of string set and gauge metrics.
This allows the associated Validates runner tests to pass for Python (test_metrics) and the related tests for Java to pass.
Java Attempted metrics failures (#31926) are to be handled in a different PR.
It was necessary to re-generate update the go protocol buffers to allow for StringSet, so that change has also been included in it's own commit. Most files are only updating a comment WRT which protocol buffer compiler is used.
See https://github.com/apache/beam/pull/32184/files/a073e790713ca547eada875c75bbd8073bb634fa..77316d7b4d53c86f716015c44186c737e7171e8e for just the real code changes, that implement StringSet and Gauge metrics support inn prism.
Fixes #31927 and #31928
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.