Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create RequestResponseIO gradle project #28706

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

damondouglas
Copy link
Contributor

This PR closes #28705 by creating a new gradle project for RequestResponseIO (RRIO).


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #28706 (d24a85e) into master (1c50fd2) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #28706   +/-   ##
=======================================
  Coverage   71.98%   71.98%           
=======================================
  Files         680      680           
  Lines      100162   100172   +10     
=======================================
+ Hits        72099    72107    +8     
- Misses      26486    26488    +2     
  Partials     1577     1577           
Flag Coverage Δ
python 82.54% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damondouglas damondouglas marked this pull request as ready for review September 27, 2023 23:33
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @damccorm for label build.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damondouglas
Copy link
Contributor Author

Run Java PreCommit

@damondouglas damondouglas merged commit dda0eb9 into apache:master Sep 28, 2023
57 checks passed
@damondouglas damondouglas deleted the rrio-project-setup branch September 28, 2023 16:08

plugins { id 'org.apache.beam.module' }
applyJavaNature(
automaticModuleName: 'org.apache.beam.sdk.io.rrio'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note - there were practices of setting these building parameters to ongoing work:

exportJavadoc: false,
publish: false

so it does not publish artifact and javadoc until the IO is ready for use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Create RequestResponseIO (RRIO) gradle project
3 participants