From 925a828d2436ff3eff1dafed5cf29b3c4ff266c1 Mon Sep 17 00:00:00 2001 From: Bryce Mecum Date: Mon, 11 Nov 2024 10:35:26 -0800 Subject: [PATCH] Fix lib/bin thing --- cpp/cmake_modules/ThirdpartyToolchain.cmake | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake index 610ab875a98a6..35ad4089e7f91 100644 --- a/cpp/cmake_modules/ThirdpartyToolchain.cmake +++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake @@ -1763,8 +1763,9 @@ macro(build_thrift) set(THRIFT_LIB_SUFFIX "md") list(APPEND THRIFT_CMAKE_ARGS "-DWITH_MT=OFF") endif() + # NOTE(amoeba): When you bump Thrift to >=0.21.0, change bin to lib set(THRIFT_LIB - "${THRIFT_PREFIX}/lib/${CMAKE_IMPORT_LIBRARY_PREFIX}thrift${THRIFT_LIB_SUFFIX}${CMAKE_IMPORT_LIBRARY_SUFFIX}" + "${THRIFT_PREFIX}/bin/${CMAKE_IMPORT_LIBRARY_PREFIX}thrift${THRIFT_LIB_SUFFIX}${CMAKE_IMPORT_LIBRARY_SUFFIX}" ) else() set(THRIFT_LIB