Skip to content

Add min_bytes and max_bytes to PageIndex #5949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tshauck opened this issue Jun 24, 2024 · 1 comment · Fixed by #5950
Closed

Add min_bytes and max_bytes to PageIndex #5949

tshauck opened this issue Jun 24, 2024 · 1 comment · Fixed by #5950
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@tshauck
Copy link
Contributor

tshauck commented Jun 24, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently PageIndex, while similar to Statistics, doesn't support max_bytes and min_bytes.

Describe the solution you'd like

Add max_bytes and min_bytes to PageIndex<T> where T: AsBytes.

Describe alternatives you've considered

Additional context

There was some discussion of this w.r.t. this ticket: apache/datafusion#10951 because f16's physical type is a fixed len binary array. Ultimately the better solution is for parquet to natively support f16 that may take longer and be more involved when it's implemented.

@alamb
Copy link
Contributor

alamb commented Jul 2, 2024

label_issue.py automatically added labels {'parquet'} from #5950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants