Skip to content

Commit cbbbe61

Browse files
authored
Exclude some long-running tests when running under miri (#1863)
* Exclude some long-running tests when running under miri * Print exit code of miri * Disable miri stacked borrows checking because it uses too much memory for github actions * Exclude another slow test from running under miri * Add link to miri issue
1 parent f191fa6 commit cbbbe61

File tree

4 files changed

+11
-15
lines changed

4 files changed

+11
-15
lines changed

.github/workflows/miri.sh

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,13 @@
66
# rustup default nightly
77

88

9-
export MIRIFLAGS="-Zmiri-disable-isolation"
9+
# stacked borrows checking uses too much memory to run successfully in github actions
10+
# re-enable if the CI is migrated to something more powerful (https://github.com/apache/arrow-rs/issues/1833)
11+
# see also https://github.com/rust-lang/miri/issues/1367
12+
export MIRIFLAGS="-Zmiri-disable-isolation -Zmiri-disable-stacked-borrows"
1013
cargo miri setup
1114
cargo clean
1215

13-
run_miri() {
14-
# Currently only the arrow crate is tested with miri
15-
# IO related tests and some unsupported tests are skipped
16-
cargo miri test -p arrow -- --skip csv --skip ipc --skip json
17-
}
18-
19-
# If MIRI fails, automatically retry
20-
# Seems like miri is occasionally killed by the github runner
21-
# https://github.com/apache/arrow-rs/issues/879
22-
for i in `seq 1 5`; do
23-
echo "Starting Arrow MIRI run..."
24-
run_miri && break
25-
echo "foo" > /tmp/data.txt
26-
done
16+
echo "Starting Arrow MIRI run..."
17+
cargo miri test -p arrow -- --skip csv --skip ipc --skip json
18+
echo "Miri finished with exit code $?"

arrow/src/array/array_union.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -436,6 +436,7 @@ mod tests {
436436
}
437437

438438
#[test]
439+
#[cfg_attr(miri, ignore)]
439440
fn test_dense_i32_large() {
440441
let mut builder = UnionBuilder::new_dense(1024);
441442

arrow/src/compute/kernels/filter.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1332,6 +1332,7 @@ mod tests {
13321332
}
13331333

13341334
#[test]
1335+
#[cfg_attr(miri, ignore)]
13351336
fn fuzz_test_slices_iterator() {
13361337
let mut rng = thread_rng();
13371338

@@ -1401,6 +1402,7 @@ mod tests {
14011402
}
14021403

14031404
#[test]
1405+
#[cfg_attr(miri, ignore)]
14041406
fn fuzz_filter() {
14051407
let mut rng = thread_rng();
14061408

arrow/src/util/bit_chunk_iterator.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -611,6 +611,7 @@ mod tests {
611611
}
612612

613613
#[test]
614+
#[cfg_attr(miri, ignore)]
614615
fn fuzz_unaligned_bit_chunk_iterator() {
615616
let mut rng = thread_rng();
616617

0 commit comments

Comments
 (0)