Deprecate array_to_json_array (#5515)

tustvold · web-flow · commit 4d0316da100b · 2024-03-15T15:44:09.000+13:00
diff --git a/arrow-json/src/writer.rs b/arrow-json/src/writer.rs
@@ -161,6 +161,7 @@ fn struct_array_to_jsonmap_array(
 }
 
 /// Converts an arrow [`Array`] into a `Vec` of Serde JSON [`serde_json::Value`]'s
+#[deprecated(note = "Use Writer")]
 pub fn array_to_json_array(array: &dyn Array) -> Result<Vec<Value>, ArrowError> {
     // For backwards compatibility, default to skip nulls
     array_to_json_array_internal(array, false)
@@ -1837,6 +1838,7 @@ mod tests {
     }
 
     #[test]
+    #[allow(deprecated)]
     fn test_array_to_json_array_for_fixed_size_list_array() {
         let expected_json = vec![
             json!([0, 1, 2]),
@@ -1859,6 +1861,7 @@ mod tests {
     }
 
     #[test]
+    #[allow(deprecated)]
     fn test_array_to_json_array_for_map_array() {
         let expected_json = serde_json::from_value::<Vec<Value>>(json!([
             [

Original file line number	Diff line number	Diff line change
`@@ -161,6 +161,7 @@ fn struct_array_to_jsonmap_array(`
`161`	`161`	`}`
`162`	`162`
`163`	`163`	/// Converts an arrow [`Array`] into a `Vec` of Serde JSON [`serde_json::Value`]'s
	`164`	`+#[deprecated(note = "Use Writer")]`
`164`	`165`	`pub fn array_to_json_array(array: &dyn Array) -> Result<Vec<Value>, ArrowError> {`
`165`	`166`	`// For backwards compatibility, default to skip nulls`
`166`	`167`	`array_to_json_array_internal(array, false)`
`@@ -1837,6 +1838,7 @@ mod tests {`
`1837`	`1838`	`}`
`1838`	`1839`
`1839`	`1840`	`#[test]`
	`1841`	`+ #[allow(deprecated)]`
`1840`	`1842`	`fn test_array_to_json_array_for_fixed_size_list_array() {`
`1841`	`1843`	`let expected_json = vec![`
`1842`	`1844`	`json!([0, 1, 2]),`
`@@ -1859,6 +1861,7 @@ mod tests {`
`1859`	`1861`	`}`
`1860`	`1862`
`1861`	`1863`	`#[test]`
	`1864`	`+ #[allow(deprecated)]`
`1862`	`1865`	`fn test_array_to_json_array_for_map_array() {`
`1863`	`1866`	`let expected_json = serde_json::from_value::<Vec<Value>>(json!([`
`1864`	`1867`	`[`