-
Notifications
You must be signed in to change notification settings - Fork 32
Make GetOptionsExt
publicly usable
#261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
These extension traits are intentionally private, as they're really just implementation details, that being said |
Hey @tustvold, somewhat related question - would you consider making the whole |
I don't think we could make it public in its current form, the API surface is simply too large and not really designed around API stability. I think probably we would need something like apache/arrow-rs#6056 to provide a coherent contract, which we could then provide a default implementation of. |
I actually ended up copying (and slightly adapting) just the Backoff and Retry implementations. The client itself wouldn't provide us value, but those seemed general enough. |
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Ideally, to implement the new
ObjectStore::get_opts
for other object stores based onreqwest
clients, we could simply callGetOptionsExt::with_get_options
on theRequestBuilder
, as is done in theobject_store
crate itself.This is not currently possible (I assume inadvertently as the trait itself is public?), since the containing
client
mod is currently private;Describe the solution you'd like
Make the trait public/exportable beyond the
object_store
crate.Describe alternatives you've considered
Repeat the logic from
GetOptionsExt::with_get_options
.Additional context
Over at Seafowl we have a custom HTTP object store implementation for legacy reasons.
The text was updated successfully, but these errors were encountered: