-
Notifications
You must be signed in to change notification settings - Fork 32
Introduce Extensions concept to object_store::GetOptions and object_store::PutOptions #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
enhancement
New feature or request
Comments
This was referenced Feb 19, 2025
|
alamb
referenced
this issue
in alamb/arrow-rs
Mar 20, 2025
* feat: add `Extensions` to object store `GetOptions` Closes #7155. * refactor: replace own `Extensions` by `http` version * feat: wire `Extensions` into HTTP stack
PinkCrow007
referenced
this issue
in PinkCrow007/arrow-rs
Mar 20, 2025
* feat: add `Extensions` to object store `GetOptions` Closes #7155. * refactor: replace own `Extensions` by `http` version * feat: wire `Extensions` into HTTP stack
Migrating from arrow-rs issue #7155 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
This problem is roughly described in apache/arrow-rs#7135, but essentially we are looking for a way to pass arbitrary implementation-specific data (such as configuration or tracing spans) originating at a high-level query API to
ObjectStore
implementations (eg caching or metrics-oriented wrappers).Describe the solution you'd like
Here we propse updating the existing
GetOption
andPutOption
types with a similarly extensible context/session type. @crepererum suggested something like the following:One downside with this approach is that there is no way to pass
GetOption
to methods likeget_ranges
andget_range
, orPutOption
toput_multipart
.Describe alternatives you've considered
In apache/arrow-rs#7135 the proposal was to introduce new
ObjectStore
methods that takes an extensible context/session type that could hold arbitrary data. This was considered too heavy in terms of the additional trait methods. This approach would have supported contextualizingget_ranges
andget_range
. From my point of view as a user of theObjectStore
API, this would be the ideal approach since it makes the context passing an explicit and easily-discoverable part of theObjectStore
API.Another alternative that has been discussed would be to initialize
ObjectStore
wrappers with the additional context needed at the outset of a query call rather than adding the context at the point whereObjectStore
methods themselves are called. For the purpose of something like propagating tracing spans, this approach is less than ideal due to the spans not being properly situated in the hierarchy of spans built in the course of setup, planning, and execution of queries.Additional context
The text was updated successfully, but these errors were encountered: