Skip to content

Commit 94cabdd

Browse files
committed
refactor: (GH-#85) Changes in benchmark after review-2
Signed-off-by: Saurabh Kumar Singh <[email protected]>
1 parent 1ea6db4 commit 94cabdd

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

.github/workflows/benchmark.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ on:
2323
branches: [main]
2424
paths:
2525
- ".github/workflows/benchmark.yml"
26+
- "ci/scripts/bench_adapt.py"
2627
workflow_dispatch:
2728
permissions:
2829
contents: read
@@ -40,19 +41,17 @@ jobs:
4041
uses: actions/setup-python@v4
4142
with:
4243
python-version: '3.9'
43-
- name: Install dependencies
44-
run: |
45-
apt-get update
46-
apt-get install -y build-essential git python3-pip
4744
- name: Install Go ${{ matrix.go }} for Benchmarks
4845
uses: actions/setup-go@v5
4946
with:
5047
go-version: ${{ matrix.go }}
5148
cache: true
5249
cache-dependency-path: go.sum
5350
- name: Run Benchmarks
54-
if: >-
55-
success() && github.event_name == 'push' && github.repository == 'apache/arrow-go' && github.ref_name == 'main'
51+
run: |
52+
ci/scripts/bench.sh --json
53+
- name: Upload results
54+
if: github.event_name == 'push' && github.repository == 'apache/arrow-go' && github.ref_name == 'main'
5655
env:
5756
CONBENCH_URL: https://conbench.ursa.dev
5857
CONBENCH_EMAIL: ${{ secrets.CONBENCH_EMAIL }}
@@ -61,4 +60,4 @@ jobs:
6160
CONBENCH_MACHINE_INFO_NAME: ${{ matrix.arch }}-debian-12
6261
run: |
6362
python3 -m pip install benchadapt@git+https://github.com/conbench/conbench.git@main#subdirectory=benchadapt/python
64-
python3 ci/scripts/go_bench_adapt.py
63+
python3 ci/scripts/bench_adapt.py

ci/scripts/bench_adapt.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
#!/usr/bin/env python3
2+
#
13
# Licensed to the Apache Software Foundation (ASF) under one
24
# or more contributor license agreements. See the NOTICE file
35
# distributed with this work for additional information

0 commit comments

Comments
 (0)