Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Optimize ams configuration to support parsing of time interval and storage related configuration items when both values and units are specified #3418

Closed
3 tasks done
Jzjsnow opened this issue Jan 23, 2025 · 0 comments · Fixed by #3423

Comments

@Jzjsnow
Copy link
Contributor

Jzjsnow commented Jan 23, 2025

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Currently, the ams configuration is inconsistent in the type of time interval related configuration items, some of which are of Duration type, such as http-server.session-timeout, and some of which are of Long type, such as refresh-external-catalogs.interval, which may be misused by the user.
In addition, storage-related parameters such as thrift-server.max-message-size only support Long type (default unit is byte). It would be more user-friendly to support user-specified units, as in the Apache Flink configuration.

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant