Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The commit.retry.num-retries configuration does not take effect when configured on the catalog. #3384

Open
2 tasks done
lintingbin opened this issue Jan 2, 2025 · 0 comments
Labels
type:bug Something isn't working

Comments

@lintingbin
Copy link
Contributor

What happened?

In our production environment, we often encounter commit failure errors in Amoro. I tried to change the commit.retry.num-retries configuration on the catalog in Amoro to 30, but found that it didn't take effect. After troubleshooting, I discovered that during Amoro commit, the commitSimpleTransaction function in the org.apache.iceberg.BaseTransaction class is executed. This function retrieves the commit.retry.num-retries parameter directly from the metadata file's content, so the configuration set on the catalog does not take effect.

Affects Versions

0.7.1

What table formats are you seeing the problem on?

Iceberg

What engines are you seeing the problem on?

AMS

How to reproduce

No response

Relevant log output

No response

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

  • I agree to follow this project's Code of Conduct
@lintingbin lintingbin added the type:bug Something isn't working label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant