Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Commit b75b413

Browse files
committed
Fixed Scala style error
1 parent 7afce3f commit b75b413

File tree

8 files changed

+15
-18
lines changed

8 files changed

+15
-18
lines changed

resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/config.scala renamed to resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import org.apache.spark.internal.Logging
2121
import org.apache.spark.internal.config.ConfigBuilder
2222
import org.apache.spark.network.util.ByteUnit
2323

24-
private[spark] object config extends Logging {
24+
private[spark] object Config extends Logging {
2525

2626
val KUBERNETES_NAMESPACE =
2727
ConfigBuilder("spark.kubernetes.namespace")

resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/constants.scala renamed to resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
*/
1717
package org.apache.spark.deploy.k8s
1818

19-
private[spark] object constants {
19+
private[spark] object Constants {
2020

2121
// Labels
2222
val SPARK_APP_ID_LABEL = "spark-app-selector"

resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import io.fabric8.kubernetes.client.utils.HttpClientUtils
2525
import okhttp3.Dispatcher
2626

2727
import org.apache.spark.SparkConf
28-
import org.apache.spark.deploy.k8s.config._
28+
import org.apache.spark.deploy.k8s.Config._
2929
import org.apache.spark.util.ThreadUtils
3030

3131
/**

resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ import scala.collection.JavaConverters._
2121
import io.fabric8.kubernetes.api.model._
2222

2323
import org.apache.spark.SparkConf
24+
import org.apache.spark.deploy.k8s.Config._
2425
import org.apache.spark.deploy.k8s.ConfigurationUtils
25-
import org.apache.spark.deploy.k8s.config._
26-
import org.apache.spark.deploy.k8s.constants._
26+
import org.apache.spark.deploy.k8s.Constants._
2727
import org.apache.spark.util.Utils
2828

2929
/**

resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ import java.io.File
2121
import io.fabric8.kubernetes.client.Config
2222

2323
import org.apache.spark.SparkContext
24+
import org.apache.spark.deploy.k8s.Config._
25+
import org.apache.spark.deploy.k8s.Constants._
2426
import org.apache.spark.deploy.k8s.SparkKubernetesClientFactory
25-
import org.apache.spark.deploy.k8s.config._
26-
import org.apache.spark.deploy.k8s.constants._
2727
import org.apache.spark.internal.Logging
2828
import org.apache.spark.scheduler.{ExternalClusterManager, SchedulerBackend, TaskScheduler, TaskSchedulerImpl}
2929
import org.apache.spark.util.ThreadUtils

resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ import scala.collection.mutable
3030
import scala.concurrent.{ExecutionContext, Future}
3131

3232
import org.apache.spark.SparkException
33-
import org.apache.spark.deploy.k8s.config._
34-
import org.apache.spark.deploy.k8s.constants._
33+
import org.apache.spark.deploy.k8s.Config._
34+
import org.apache.spark.deploy.k8s.Constants._
3535
import org.apache.spark.rpc.{RpcAddress, RpcEndpointAddress, RpcEnv}
3636
import org.apache.spark.scheduler.{ExecutorExited, SlaveLost, TaskSchedulerImpl}
3737
import org.apache.spark.scheduler.cluster.{CoarseGrainedSchedulerBackend, SchedulerBackendUtils}

resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactorySuite.scala

+3-6
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,16 @@ package org.apache.spark.scheduler.cluster.k8s
1919
import scala.collection.JavaConverters._
2020

2121
import io.fabric8.kubernetes.api.model.{Pod, _}
22-
import io.fabric8.kubernetes.client.KubernetesClient
2322
import org.mockito.MockitoAnnotations
2423
import org.scalatest.{BeforeAndAfter, BeforeAndAfterEach}
2524

2625
import org.apache.spark.{SparkConf, SparkFunSuite}
27-
import org.apache.spark.deploy.k8s.config._
28-
import org.apache.spark.deploy.k8s.constants._
26+
import org.apache.spark.deploy.k8s.Config._
27+
import org.apache.spark.deploy.k8s.Constants._
2928

3029
class ExecutorPodFactorySuite extends SparkFunSuite with BeforeAndAfter with BeforeAndAfterEach {
3130
private val driverPodName: String = "driver-pod"
3231
private val driverPodUid: String = "driver-uid"
33-
private val driverUrl: String = "driver-url"
3432
private val executorPrefix: String = "base"
3533
private val executorImage: String = "executor-image"
3634
private val driverPod = new PodBuilder()
@@ -54,7 +52,6 @@ class ExecutorPodFactorySuite extends SparkFunSuite with BeforeAndAfter with Bef
5452
.set(KUBERNETES_EXECUTOR_POD_NAME_PREFIX, executorPrefix)
5553
.set(EXECUTOR_DOCKER_IMAGE, executorImage)
5654
}
57-
private var kubernetesClient: KubernetesClient = _
5855

5956
test("basic executor pod has reasonable defaults") {
6057
val factory = new ExecutorPodFactoryImpl(baseConf)
@@ -130,7 +127,7 @@ class ExecutorPodFactorySuite extends SparkFunSuite with BeforeAndAfter with Bef
130127
ENV_EXECUTOR_PORT -> "10000") ++ additionalEnvVars
131128

132129
assert(executor.getSpec.getContainers.size() === 1)
133-
assert(executor.getSpec.getContainers.get(0).getEnv().size() === defaultEnvs.size)
130+
assert(executor.getSpec.getContainers.get(0).getEnv.size() === defaultEnvs.size)
134131
val mapEnvs = executor.getSpec.getContainers.get(0).getEnv.asScala.map {
135132
x => (x.getName, x.getValue)
136133
}.toMap

resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackendSuite.scala

+3-3
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@ import org.mockito.{AdditionalAnswers, ArgumentCaptor, Mock, MockitoAnnotations}
2626
import org.mockito.Matchers.{any, eq => mockitoEq}
2727
import org.mockito.Mockito.{doNothing, never, times, verify, when}
2828
import org.scalatest.BeforeAndAfter
29-
import org.scalatest.mock.MockitoSugar._
29+
import org.scalatest.mockito.MockitoSugar._
3030
import scala.collection.JavaConverters._
3131
import scala.concurrent.Future
3232

3333
import org.apache.spark.{SparkConf, SparkContext, SparkFunSuite}
34-
import org.apache.spark.deploy.k8s.config._
35-
import org.apache.spark.deploy.k8s.constants._
34+
import org.apache.spark.deploy.k8s.Config._
35+
import org.apache.spark.deploy.k8s.Constants._
3636
import org.apache.spark.rpc._
3737
import org.apache.spark.scheduler.{ExecutorExited, LiveListenerBus, SlaveLost, TaskSchedulerImpl}
3838
import org.apache.spark.scheduler.cluster.CoarseGrainedClusterMessages.{RegisterExecutor, RemoveExecutor}

0 commit comments

Comments
 (0)