Skip to content

Commit e24ecda

Browse files
authored
Merge pull request #27 from liyinan926/master
Re-arranged some test cases
2 parents 737c23a + 41d32ca commit e24ecda

File tree

1 file changed

+27
-24
lines changed

1 file changed

+27
-24
lines changed

integration-test/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala

Lines changed: 27 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,15 @@ private[spark] class KubernetesSuite extends FunSuite with BeforeAndAfterAll wit
4040
private var kubernetesTestComponents: KubernetesTestComponents = _
4141
private var sparkAppConf: SparkAppConf = _
4242

43-
private val driverImage = System.getProperty("spark.docker.test.driverImage", "spark-driver:latest")
44-
private val executorImage = System.getProperty("spark.docker.test.executorImage", "spark-executor:latest")
45-
private val initContainerImage = System.getProperty("spark.docker.test.initContainerImage", "spark-init:latest")
43+
private val driverImage = System.getProperty(
44+
"spark.docker.test.driverImage",
45+
"spark-driver:latest")
46+
private val executorImage = System.getProperty(
47+
"spark.docker.test.executorImage",
48+
"spark-executor:latest")
49+
private val initContainerImage = System.getProperty(
50+
"spark.docker.test.initContainerImage",
51+
"spark-init:latest")
4652

4753

4854
override def beforeAll(): Unit = {
@@ -91,11 +97,6 @@ private[spark] class KubernetesSuite extends FunSuite with BeforeAndAfterAll wit
9197
runSparkPiAndVerifyCompletion(appArgs = Array("5"))
9298
}
9399

94-
test("Run SparkPi using the remote example jar.") {
95-
sparkAppConf.set("spark.kubernetes.initContainer.image", initContainerImage)
96-
runSparkPiAndVerifyCompletion(appResource = REMOTE_EXAMPLES_JAR_URI)
97-
}
98-
99100
test("Run SparkPi with custom driver pod name, labels, annotations, and environment variables.") {
100101
sparkAppConf
101102
.set("spark.kubernetes.driver.pod.name", "spark-integration-spark-pi")
@@ -140,17 +141,30 @@ private[spark] class KubernetesSuite extends FunSuite with BeforeAndAfterAll wit
140141
})
141142
}
142143

143-
test("Run SparkPi using the remote example jar with a test secret mounted into the driver and " +
144-
"executor pods") {
144+
test("Run PageRank using remote data file") {
145145
sparkAppConf
146+
.set("spark.kubernetes.mountDependencies.filesDownloadDir",
147+
CONTAINER_LOCAL_FILE_DOWNLOAD_PATH)
148+
.set("spark.files", REMOTE_PAGE_RANK_DATA_FILE)
149+
.set("spark.kubernetes.initContainer.image", initContainerImage)
150+
runSparkPageRankAndVerifyCompletion(
151+
appArgs = Array(CONTAINER_LOCAL_DOWNLOADED_PAGE_RANK_DATA_FILE))
152+
}
153+
154+
test("Run PageRank using remote data file with test secret mounted into the driver and " +
155+
"executors") {
156+
sparkAppConf
157+
.set("spark.kubernetes.mountDependencies.filesDownloadDir",
158+
CONTAINER_LOCAL_FILE_DOWNLOAD_PATH)
159+
.set("spark.files", REMOTE_PAGE_RANK_DATA_FILE)
146160
.set(s"spark.kubernetes.driver.secrets.$TEST_SECRET_NAME", TEST_SECRET_MOUNT_PATH)
147161
.set(s"spark.kubernetes.executor.secrets.$TEST_SECRET_NAME", TEST_SECRET_MOUNT_PATH)
148-
sparkAppConf.set("spark.kubernetes.initContainer.image", initContainerImage)
162+
.set("spark.kubernetes.initContainer.image", initContainerImage)
149163

150164
createTestSecret()
151165

152-
runSparkPiAndVerifyCompletion(
153-
appResource = REMOTE_EXAMPLES_JAR_URI,
166+
runSparkPageRankAndVerifyCompletion(
167+
appArgs = Array(CONTAINER_LOCAL_DOWNLOADED_PAGE_RANK_DATA_FILE),
154168
driverPodChecker = (driverPod: Pod) => {
155169
doBasicDriverPodCheck(driverPod)
156170
checkTestSecret(driverPod, withInitContainer = true)
@@ -161,14 +175,6 @@ private[spark] class KubernetesSuite extends FunSuite with BeforeAndAfterAll wit
161175
})
162176
}
163177

164-
test("Run PageRank using remote data file") {
165-
sparkAppConf
166-
.set("spark.kubernetes.mountDependencies.filesDownloadDir", CONTAINER_LOCAL_FILE_DOWNLOAD_PATH)
167-
.set("spark.files", REMOTE_PAGE_RANK_DATA_FILE)
168-
.set("spark.kubernetes.initContainer.image", initContainerImage)
169-
runSparkPageRankAndVerifyCompletion(appArgs = Array(CONTAINER_LOCAL_DOWNLOADED_PAGE_RANK_DATA_FILE))
170-
}
171-
172178
private def runSparkPiAndVerifyCompletion(
173179
appResource: String = CONTAINER_LOCAL_SPARK_DISTRO_EXAMPLES_JAR,
174180
driverPodChecker: Pod => Unit = doBasicDriverPodCheck,
@@ -322,9 +328,6 @@ private[spark] object KubernetesSuite {
322328

323329
val CONTAINER_LOCAL_FILE_DOWNLOAD_PATH = "/var/spark-data/spark-files"
324330

325-
val REMOTE_EXAMPLES_JAR_URI =
326-
"https://storage.googleapis.com/spark-k8s-integration-tests/jars/spark-examples_2.11-2.3.0.jar"
327-
328331
val REMOTE_PAGE_RANK_DATA_FILE =
329332
"https://storage.googleapis.com/spark-k8s-integration-tests/files/pagerank_data.txt"
330333
val CONTAINER_LOCAL_DOWNLOADED_PAGE_RANK_DATA_FILE =

0 commit comments

Comments
 (0)