Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected integration time values for the OceanFX #237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

padalev
Copy link
Contributor

@padalev padalev commented Feb 26, 2024

The stored values for the integration time of the OceanFX in libseabreeze were not correct.
I corrected the values with this minor change.

Copy link
Owner

@ap-- ap-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! ❤️

const long FlameXSpectrometerFeature::INTEGRATION_TIME_INCREMENT = 1000;
const long FlameXSpectrometerFeature::INTEGRATION_TIME_MINIMUM = 10;
const long FlameXSpectrometerFeature::INTEGRATION_TIME_MAXIMUM = 10000000;
const long FlameXSpectrometerFeature::INTEGRATION_TIME_INCREMENT = 1;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that this actually works?

Changing the integration time increment usually influences the way the usb communication works.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @padalev,

it would be great if you could confirm the above ☺️

@ap--
Copy link
Owner

ap-- commented Jun 27, 2024

@padalev in case you have time, it would be great if you could confirm that your change works, and that integration times are not off by a factor of 1000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants