Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] difficult to choose the correct charset option to extract a valid app #1052

Open
gingerbeardman opened this issue Feb 23, 2022 · 2 comments

Comments

@gingerbeardman
Copy link
Contributor

Configuration

  • Keka version: 1.2.52 (4882)
  • macOS version: 10.14.6 (18G9323) my old Mojave machine

Describe the bug

difficult to choose the correct charset option to extract a valid app

Wrong choice results in corrupt .app

To Reproduce

Steps to reproduce the behavior:

  1. Download the Code Runner app https://coderunnerapp.com/download
  2. Unzip using Keka
  3. Asks user to choose charset

Wrong choice results in corrupt .app

Expected behaviour

  • Archive Utility expands it without any user input
@aonez aonez added the core label Feb 24, 2022
@aonez aonez modified the milestones: 1.2.53, Look at Feb 24, 2022
@aonez aonez added enhancement and removed bug labels Feb 24, 2022
@aonez
Copy link
Owner

aonez commented Feb 24, 2022

Without implementing something like UniversalDetector is hard to guess the correct option. In this case it is UTF-8, like in the case of #577. I can probably set UTF-8 as the selected option (even try it by default) if the decoding worked.

Anyway I still don't understand why some developers keep adding resources with characters on some filenames that may break the integrity of the code signature.

@gingerbeardman
Copy link
Contributor Author

It's crazy, of course most of them remain hidden from our eyes in the app bundles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants