Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to properly combine it with import/extensions rule in an ESM project? #14

Closed
mbonaci opened this issue May 3, 2024 · 1 comment
Closed

Comments

@mbonaci
Copy link

mbonaci commented May 3, 2024

If I use your conf from README and also do (FYI I'm using airbnb eslint conf):

"import/extensions": [
  "error",
  "ignorePackages",
  {
    "js": "always",
    "cjs": "always",
    "jsx": "always",
    "ts": "never",
    "tsx": "never",
    "json": "always"
  }
]

then eslint doesn't complain if I import a ts/tsx file without an extension, e.g.:

import Root from 'components/Root'; // no errors for this tsx file

If I change import/extensions conf and say "tsx": "always" instead, then I get:

Missing file extension "tsx" for "components/Root" eslint[import/extensions]

When I import it as a js file there are no errors and that's great:

import Root from 'components/Root.js'; // great, but I need the error when the .js extension is missing

So how come your extension isn't jumping out of joy to step in and save the day :)

Thanks

@mbonaci
Copy link
Author

mbonaci commented May 3, 2024

Closing. I've just realized it happens only when import uses a webpack alias, so this is a dupe of: #10

@mbonaci mbonaci closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant