From 029463166afc073351bda560c8c32b6502260063 Mon Sep 17 00:00:00 2001
From: Jon C <me@jonc.dev>
Date: Fri, 9 Aug 2024 14:12:49 +0200
Subject: [PATCH] ci: Add rule for Firedancer review on native programs (#2233)

* ci: Add rule for Firedancer review on native programs

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts. In the
past, the Firedancer team has requested to be included in reviews that
touch code in the native programs.

To make it harder to forget, add an automated to any PRs that touch
native programs. I've omitted test crates and and the ZK Token Proof
program, since I believe that won't be included in Firedancer.

* Add stake and vote in SDK

* Update language
---
 .mergify.yml | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/.mergify.yml b/.mergify.yml
index d50fd5e1e277ba..ae3b1a27d4565a 100644
--- a/.mergify.yml
+++ b/.mergify.yml
@@ -183,6 +183,29 @@ pull_request_rules:
           2. Open a follow-up PR to update the JavaScript client `@solana/web3.js` ([example](https://github.com/solana-labs/solana-web3.js/pull/2868/files))
 
           Thank you for keeping the RPC clients in sync with the server API @{{author}}.
+  - name: Reminder to add Firedancer team to changes in `programs/` and `sdk/`
+    conditions:
+      - or:
+        - files~=^programs/address-lookup-table/src/.*\.rs$
+        - files~=^programs/bpf_loader/src/.*\.rs$
+        - files~=^programs/compute_budget/src/.*\.rs$
+        - files~=^programs/config/src/.*\.rs$
+        - files~=^programs/loader-v4/src/.*\.rs$
+        - files~=^programs/stake/src/.*\.rs$
+        - files~=^programs/system/src/.*\.rs$
+        - files~=^programs/vote/src/.*\.rs$
+        - files~=^programs/zk-elgamal-proof/src/.*\.rs$
+        - files~=^sdk/program/src/stake.*\.rs$  # includes stake_history.rs
+        - files~=^sdk/program/src/vote/.*\.rs$
+    actions:
+      comment:
+        message: |
+          The Firedancer team maintains a line-for-line reimplementation of the
+          native programs, and until native programs are moved to BPF, those
+          implementations must exactly match their Agave counterparts.
+          If this PR represents a change to a native program implementation (not
+          tests), please include a reviewer from the Firedancer team. And please
+          keep refactors to a minimum.
 
 commands_restrictions:
   # The author of copied PRs is the Mergify user.