Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphin.Legend should hide node halo as well #488

Open
romulorod opened this issue Jun 12, 2023 · 2 comments
Open

Graphin.Legend should hide node halo as well #488

romulorod opened this issue Jun 12, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@romulorod
Copy link

romulorod commented Jun 12, 2023

Describe the bug

If the node has a halo, when we click on the legend to "hide" that node, the halo is still fully visible but it should take the node visibility into account to make it also invisible, or less visible.

Your Example Website or App

https://codesandbox.io/s/suspicious-heisenberg-rhzvzc?file=/App.tsx

Steps to Reproduce the Bug or Issue

Add a legend to a chart, display nodes with halos and click the legend to toggle node visibility.

Expected behavior

The halo should also go invisible alongside the node.

Screenshots or Videos

No response

Platform

  • OS: Linux
  • Browser: Edge, Chrome
  • Version: LTS

Additional context

No response

@pomelo-nwu
Copy link
Member

@romulorod If you set the style configuration for Graphin, you also need to manually specify its status configuration via props.nodeStateStyles,You can check out the link below:
https://codesandbox.io/s/recursing-shockley-nqcx3g?file=/App.tsx

image

@pomelo-nwu pomelo-nwu added the help wanted Extra attention is needed label Jun 13, 2023
@romulorod
Copy link
Author

@pomelo-nwu this was exactly what I needed, I wasn't aware of that props, nodeStateStyles, thank you!! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants