refactor: disable dirty rectangle rendering #6727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Aarebecca
commented
Jan 14, 2025
•
Aarebecca
commented
- G Canvas 渲染器关闭脏矩形渲染优化
WalkthroughThis pull request refactors the G Canvas renderer by disabling the dirty rectangle rendering capability. This change affects how the canvas is rendered, potentially impacting performance and rendering behavior. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| @@ -360,6 +360,10 @@ function createRenderers(renderer: CanvasConfig['renderer'], layersName: CanvasL | |||
| layersName.map((layer) => { | |||
| const instance = renderer?.(layer) || new CanvasRenderer(); | |||
|
|
|||
| if (instance instanceof CanvasRenderer) { | |||
| instance.setConfig({ enableDirtyRectangleRendering: false }); | |||
There was a problem hiding this comment.
Disabling dirty rectangle rendering may impact performance, especially in scenarios with frequent updates or large canvases. Ensure this change is intended and tested for performance implications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.