feat: add plane-node for v5 #5189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
有变更的 API 麻烦更新下对应的文档呢，位于 |
Aarebecca
reviewed
Nov 29, 2023
packages/g6/src/util/shape3d.ts
Outdated
| @@ -104,7 +106,7 @@ export const createShape3D = ( | |||
| ]); | |||
| break; | |||
| case 'plane': | |||
| shape.scale([style.width / GEOMETRY_SIZE, style.depth / GEOMETRY_SIZE]); | |||
| shape.scale(style.width / GEOMETRY_SIZE, style.depth / GEOMETRY_SIZE); | |||
There was a problem hiding this comment.
scale(scaling: vec3 | vec2 | number, y?: number, z?: number): this; scale 第二个参数是 y 值，确认下是否正确呢
There was a problem hiding this comment.
改好啦
如果有参加 IssueHunt 计划，请将相关的 Issue 回复到下面哦～
|
#5094 添加三层拓扑-demo案例 |
Aarebecca
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change
feat: 新增plane平面节点
feat: 添加demo案例
screenity.webm