Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve developer contribution process #2951

Closed
jfstephe opened this issue Jun 8, 2021 · 3 comments
Closed

Improve developer contribution process #2951

jfstephe opened this issue Jun 8, 2021 · 3 comments
Labels
Outdate This issue is too old to be resolved

Comments

@jfstephe
Copy link

jfstephe commented Jun 8, 2021

  • [ x ] I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

Creating a PR for this project is painful. Building the app is not straight forward.

Building this on Ubuntu doesn't work. Would be good to know what environment you run the npm commands in.

yarn isn't a dependency so when eventually I tried powershell I had to globally install that too.

Also, the tests fail for me in web-worker related code. I was running on node v15.11.0 but again... no minimum version is specified so I don't know if this is ok or not?!?

What does the proposed API look like?

Clearer instructions working tests please!

@Yanyan-Wang
Copy link
Contributor

we run npm run build on mac. What is the error message on your Ubuntu?

@ensconced
Copy link
Contributor

What is the current correct version of node to use for the project? Could we add a .nvmrc file?
Also, after a fresh clone of the repo and running npm install I get this error message - it seems like we have conflicting requirements for the tslint version.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: g6@undefined
npm ERR! Found: [email protected]
npm ERR! node_modules/tslint
npm ERR!   tslint@"^6.1.3" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer tslint@"^5.11.0" from [email protected]
npm ERR! node_modules/tslint-config-airbnb
npm ERR!   tslint-config-airbnb@"^5.11.2" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/ensconced/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/ensconced/.npm/_logs/2022-08-27T16_41_19_519Z-debug-0.log

@Aarebecca Aarebecca added the Outdate This issue is too old to be resolved label Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

This issue has been closed because it has been outdate for a long time.
Please open a new issue if you still need help.
这个 issue 已经被关闭,因为 它已经过期很久了
如果你仍然需要帮助,请创建一个新的 issue。

@github-actions github-actions bot closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Outdate This issue is too old to be resolved
Projects
None yet
Development

No branches or pull requests

4 participants