This repository has been archived by the owner on Nov 5, 2023. It is now read-only.
fix small nits #153
Merged
fix small nits #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
reviewed
Oct 31, 2023
| @@ -123,7 +123,7 @@ pub fn tx_env_with_recovered(transaction: &TransactionSignedEcRecovered) -> TxEn | |||
|
|
|||
| #[cfg(feature = "optimism")] | |||
| { | |||
| let mut envelope_buf = Vec::default(); | |||
| let mut envelope_buf = Vec::new(); | |||
There was a problem hiding this comment.
Can we instead allocate this with capacity? This is called a lot, so this reallocation may hit perf.
Suggested change
| let mut envelope_buf = Vec::new(); | |
| let mut envelope_buf = Vec::with_capacity(transaction.length_without_header()); |
clabby
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.