Prepare / release 4.7.2

[parrt]

Howdy folks: @pboyer, @mike-lischke, @janyou, @ewanmellor, @hanjoes, @ericvergnaud et al I'd like to get a 4.7.2 release out some time in the next few weeks. Can you let me know what must go in this release and what would be nice? We have to fix the following for example because it prevents Swift from working and it highlighted a bug in the Java version: issue 2372

[ewanmellor]

The Swift runtime is passing all my tests, and we got one confirm on #2372, so as far as I'm concerned, the Swift runtime is good to go for 4.7.2.

Note that this release will be Swift 4.2 only -- it's incompatible with earlier releases. That's usually not a problem for the Swift ecosystem given how aggressively they're pushing forward at the moment, but it's something to be aware of. I put it in the documentation already.

[parrt]

Excellent. great. @mike-lischke what more stuff should we get in for 4.7.2?

[mike-lischke]

I see nothing else that is still pending for 4.7.2, from the C++ runtime side. Good to go...

[ericvergnaud]

Would be great to have #2412 for js, if you can wait a day or 2. Hoping @plaurent will submit a PR. If not it's a trivial fix.

[parrt]

Sure, @ericvergnaud i'm in no rush.

[plaurent]

@ericvergnaud Looks like commit dd3af94 from January of this year has already fixed this the bug in master. So, I will close my issue and look forward to the imminent release of 4.7.2. Thank you.

(Incidentally, mvn clean for antlr4 master fails for me on both Mac OS and Linux with the error Plugin org.antlr:antlr4-maven-plugin:4.7.2-SNAPSHOT or one of its dependencies could not be resolved: Could not find artifact org.antlr:antlr4-maven-plugin:jar:4.7.2-SNAPSHOT)

[parrt]

@plaurent I believe that you have to do mvn install not mvn compile etc... as the build process has to use some things that are created and installed on the fly.

[plaurent]

@parrt Ok was following the build instructions here (https://github.com/antlr/antlr4/blob/master/doc/building-antlr.md) where the step before mvn install was "mvn clean" and that was failing.

Should we just remove the "mvn clean" step?

[parrt]

ah. maybe so. Forget the clean and try the install.

[parrt]

ok, gang. i'm starting the release process!

[parrt]

Hmm...getting

/private/var/folders/93/9kzk2ccm8xj8k70059b28jk80000gp/T/BaseSwiftTest-main-1545087448994/testcase-1545087449004/Sources/testcase-1545087449004/TBaseListener.swift:3:8: error: no such module 'Antlr4'
import Antlr4
       ^

from swith. @ewanmellor @hanjoes ? I have Xcode 10.1 installed.

Update: ok with java 7, the Swift target appears to test ok.

[parrt]

Ugh. Java world has turned to shit. Now I'm getting:

java.lang.NoSuchMethodError: java.nio.CharBuffer.flip()Ljava/nio/CharBuffer;

Was working with java 7 last month :( That is apparently a version issue. Yep, this causes multiple java test failures:

java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer;

	at org.antlr.v4.runtime.CharStreams.fromChannel(CharStreams.java:277)
	at org.antlr.v4.runtime.CharStreams.fromPath(CharStreams.java:88)
	at org.antlr.v4.runtime.CharStreams.fromPath(CharStreams.java:76)
	at org.antlr.v4.test.runtime.java.TestCharStreams.fromSMPUTF8PathHasExpectedSize(TestCharStreams.java:67)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
	at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:239)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)

That

				utf8BytesIn.flip();

code has been in there for almost 2 years. grrr...not sure how to fix. java 7 should handle it.

[ewanmellor]

Re the JDK 7 issue, check out rototor's comment here: plasma-umass/doppio#497

Personally, I think you should drop JDK 7 support. It is no longer receiving public bug fixes from Oracle, so using it in any form is asking for a security problem.

[parrt]

Hmm...yeah, does moving to java 8 cause anybody problems though in real world? Will it break a lot of stuff? I can't remember the issues...oh, was it android forking off at 1.7?

[ewanmellor]

Well if it's Android that you actually care about, we should have Android tests running on Travis. Would that just be adding it to the matrix, or is there more to it?

I notice that the JDK 7 tests are passing on Travis at the moment, but if I understand correctly from that issue I cross-referenced, this issue would only show up if you compiled on JDK 9 but ran on earlier JDKs. I don't think any of the Travis tests are doing that right now.

[parrt]

ok, figured it out. I build 4.7.2 with java 10 and installed locally. all tests are passing locally. starting release process.

[KvanTTT]

Is StringTemplate library updated to the latest version (4.1)?

[parrt]

ooops. sorry. i left it as 4.0.8. rats. anyway, it's all pushed now, even C++, C# and others