Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom rules lost after update config #218

Open
5 of 7 tasks
Krysl opened this issue Jul 11, 2024 · 1 comment
Open
5 of 7 tasks

custom rules lost after update config #218

Krysl opened this issue Jul 11, 2024 · 1 comment

Comments

@Krysl
Copy link

Krysl commented Jul 11, 2024

Describe the bug

I have some custom rules in %AppData%\Code\User\settings.json-explorer.fileNesting.patterns
after update config by this extension, the custom rules are gone.

Reproduction

  1. add some custom rule in %AppData%\Code\User\settings.json, under explorer.fileNesting.patterns
  2. open Command Palette and run command File Nesting Updater: Update config now
  3. you will see the custom rule gone

System Info

System:
    OS: Windows 10 10.0.19045

Used Package Manager

n/a

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Contributions

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)
@joshistoast
Copy link
Contributor

Can confirm this happens for me too, annoying when I want to extend it.
Maybe a comment can be added to the end for the updater to ignore that line? Better yet it should only replace or update what's in the config as opposed to that whole section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants