Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_child_alias_with_parent_path is failing from Fluent image update #3591

Open
hpohekar opened this issue Dec 19, 2024 · 2 comments
Open
Assignees

Comments

@hpohekar
Copy link
Collaborator

hpohekar commented Dec 19, 2024

It works fine for 25R1 but fails for 25R2. (failing from yesterday's Fluent image update)

"constant" is now changed to "value" for 25R2.

Earlier it was -

solver.settings.setup.materials.fluid["air"] = {
        "density": {"option": "ideal-gas"},
        "specific_heat": {"value": 1006.43, "option": "constant"},
        "thermal_conductivity": {"value": 0.0242, "option": "constant"},
        "molecular_weight": {"value": 28.966, "option": "constant"},
    }
assert (
        solver.settings.setup.models.discrete_phase.numerics.node_based_averaging.kernel._child_aliases
        == {
            "gaussian_factor": ("../gaussian_factor", "gaussian-factor"),
            "option": ("../kernel_type", "option"),
        }
    )

Now -

solver.settings.setup.materials.fluid["air"] = {
        "density": {"option": "ideal-gas"},
        "specific_heat": {"value": 1006.43, "option": "value"},
        "thermal_conductivity": {"value": 0.0242, "option": "value"},
        "molecular_weight": {"value": 28.966, "option": "value"},
    }
>>> solver.settings.setup.models.discrete_phase.numerics.node_based_averaging.kernel._child_aliases
{'gaussian_factor': '../gaussian_factor', 'option': '../kernel_type'}

I tried to fix those errors first but there are also many other changes in 25R2 therefore we are skipping this test for now.

@hpohekar
Copy link
Collaborator Author

@mkundu1
Copy link
Contributor

mkundu1 commented Jan 2, 2025

There is a change in allowed values. In 25.1:

>>> solver.settings.setup.materials.fluid["air"].density.option.allowed_values()
['constant', 'ideal-gas', 'incompressible-ideal-gas', 'rgp-table', 'real-gas-soave-redlich-kwong', 'real-gas-peng-robinson', 'real-gas-aungier-redlich-kwong', 'real-gas-redlich-kwong', 'real-gas-nist', 'boussinesq', 'piecewise-linear', 'piecewise-polynomial', 'polynomial', 'expression', 'compressible-liquid']

In 25.2:

>>> solver.settings.setup.materials.fluid["air"].density.option.allowed_values()
['value', 'ideal-gas', 'incompressible-ideal-gas', 'rgp-table', 'real-gas-soave-redlich-kwong', 'real-gas-peng-robinson', 'real-gas-aungier-redlich-kwong', 'real-gas-redlich-kwong', 'real-gas-nist', 'boussinesq', 'piecewise-linear', 'piecewise-polynomial', 'polynomial', 'compressible-liquid']

@gyeole Let us know if this is expected.

@mkundu1 mkundu1 assigned gyeole and unassigned mkundu1 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants