Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using non-public methods from requests_auth #645

Open
Andy-Grigg opened this issue Aug 20, 2024 · 1 comment
Open

Stop using non-public methods from requests_auth #645

Andy-Grigg opened this issue Aug 20, 2024 · 1 comment
Labels
enhancement New features or code improvements

Comments

@Andy-Grigg
Copy link
Contributor

Andy-Grigg commented Aug 20, 2024

📝 Description of the feature

Split from #639

We currently use non-public methods within requests_auth to work around some OIDC issues, specifically (quoting from #639 (comment)):

The issue, as I recall, was if you provide a refresh token to the builder you can get into a situation where the initial request to get an access token also triggers the refresh token to be rotated. I don't think this was properly handled in requests-auth, and we ended up with an out of date refresh token.

This became a problem recently where requests_auth was updated from 7 to 8, which broke this package.

We should review the current behavior to see if this is still an issue. If it is, we should see if we can get this functionality contributed to the requests_auth package.

💡 Steps for implementing the feature

  1. Check if we still need to use the non-public methods
  2. If yes, contribute an alternative approach upstream

🔗 Useful links and references

https://github.com/Colin-b/requests_auth

@Andy-Grigg Andy-Grigg added the enhancement New features or code improvements label Aug 20, 2024
@Andy-Grigg Andy-Grigg changed the title Add ... Stop using non-public methods from requests_auth Aug 20, 2024
@Andy-Grigg
Copy link
Contributor Author

Currently blocked, there doesn't seem to be any good way of working round this issue without proposing some major changes to requests_auth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

No branches or pull requests

1 participant